D821: unamend: move fb extension unamend to core

singhsrb (Saurabh Singh) phabricator at mercurial-scm.org
Thu Sep 28 14:28:43 EDT 2017


singhsrb added a comment.


  I just wanted to mention that unamend command does not track copytrace information properly. For example, if we do:
  
    touch dummy
    hg commit -Aqm 'dummy'
    hg cp dummy dummy2
    hg commit -Aqm 'dummy2'
    hg cp dummy2 dummy3 
    hg amend
    hg log -f dummy3
    hg unamend
    hg amend
    hg log -f dummy3
  
  Notice the difference in output on step 10 and 7. While 7 correctly records the copy information indicating that dummy3 was copied from dummy, 10 considers dummy3 a new file.
  
  We may want to fix this before taking unamend to core because the corresponding amend command does handle copytracing properly.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D821

To: pulkit, #hg-reviewers, durham
Cc: singhsrb, durham, mercurial-devel


More information about the Mercurial-devel mailing list