D803: extdiff: allow pager to be used

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Sep 29 18:29:39 EDT 2017


yuja added a comment.


  > The difference between core commands and extdiff commands here is core commands have
  >  `pager.attend-*` set to True by default. But extdiff commands have `attend-*` set to
  >  `False` to not cause surprises.
  
  That's only true for page-able commands. You can't get pager for e.g. `hg version` by
  setting `pager.attend-version=True` unless you have the pager extension enabled.
  So the pager.attend-* option seems tricky as it is right now. That's probably why it
  isn't documented, and we suggest using pager.ignore instead.
  
  > To be consistent, we can enable pager by default and allow it to be disabled via
  >  `attend-*` configs, just like core hg commands. Since we have already BC on "log"
  >  (default changed from not using pager to use pager), I think it's okay to BC here.
  >  That looks cleaner than adding more config flags?
  
  Given GUI diff is one of the main use case of extdiff, it's probably unacceptable to
  introduce BC of breaking it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D803

To: quark, #hg-reviewers, yuja
Cc: yuja, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list