D855: py3: use bytes instead of str

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Sat Sep 30 09:00:36 EDT 2017


durin42 added inline comments.

INLINE COMMENTS

> merge.py:993
>              _("note: merging %s and %s using bids from ancestors %s\n") %
> -            (wctx, mctx, _(' and ').join(str(anc) for anc in ancestors)))
> +            (wctx, mctx, _(' and ').join(bytes(anc) for anc in ancestors)))
>  

Do we know ancestors is always nodes? if we get a revnum instead of a node id this won't work right on Python 3...

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D855

To: pulkit, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list