D3047: push: avoid using repo.lookup() for converting to nodeid

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Apr 3 19:13:58 EDT 2018


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D3047#49274, @indygreg wrote:
  
  > I'll likely take this series. But part of me wonders if we should be performing conversion on the changelog instead. I guess it depends on whether the string inputs should resolve names and other things not known to the changelog itself. For converting integer revision numbers to nodes, I would argue we should go through the changelog.
  >
  > Anyway, we'll likely have a bikeshed about all of this once we establish a formal interface for the changelog. That's a bit of a ways off, however. These changes seem fine for today.
  
  
  Sure, we can talk about that later :) I think I'm at least moving us closer to that by moving out the handling of user-supplied strings.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3047

To: martinvonz, #hg-reviewers, indygreg
Cc: mercurial-devel


More information about the Mercurial-devel mailing list