D3055: localrepo: use revsymbol() in lookup()
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue Apr 3 19:33:46 EDT 2018
martinvonz added a comment.
In https://phab.mercurial-scm.org/D3055#49290, @indygreg wrote:
> `scmutil.revsymbol()` just calls `repo[x]`. So what is your intention here?
See https://phab.mercurial-scm.org/D3024, including the discussion with Yuya there. In short, revsymbol will gradually take over responsibility from changectx.__init__ for interpreting strings.
> FWIW, we must preserve `repo.lookup('0')` resolving to revision 0 because `share.poolnaming=identity` relies on it.
That will continue to work, since '0' is a string.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3055
To: martinvonz, #hg-reviewers
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list