D2948: wireproto: syntax for encoding CBOR into frames

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Apr 4 09:21:10 EDT 2018


yuja added inline comments.

INLINE COMMENTS

> stringutil.py:526
> +                   __future__.unicode_literals.compiler_flag, True)
> +    return eval(code, globs, {})

Can't we use `ast.literal_eval()` instead of unsafe `eval()` ?

https://docs.python.org/2.7/library/ast.html#ast.literal_eval

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2948

To: indygreg, #hg-reviewers, durin42
Cc: yuja, durin42, mercurial-devel


More information about the Mercurial-devel mailing list