D3029: tests: add test extension implementing custom filelog storage

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Apr 4 14:03:04 EDT 2018


durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.


  One thing that I'm 99% sure is a bug. The "ew" comment is not actionable, it just feels bad.

INLINE COMMENTS

> simplestorerepo.py:35-44
> +def validatenode(node):
> +    if isinstance(node, int):
> +        raise ValueError('expected node; got int')
> +
> +    if len(node) != 20:
> +        raise ValueError('expected 20 byte node')
> +

ew

> simplestorerepo.py:215-216
> +    def candelta(self, baserev, rev):
> +        validaterev(rev)
> +        validaterev(rev)
> +

should one of these be baserev?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3029

To: indygreg, #hg-reviewers, durin42
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list