D3029: tests: add test extension implementing custom filelog storage

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Apr 4 14:57:29 EDT 2018


durin42 added inline comments.

INLINE COMMENTS

> indygreg wrote in simplestorerepo.py:35-44
> Why?
> 
> The point of these functions is to help validate the interface. There are surprisingly few failures in core due to this type checking.
> 
> Manifests and changelog, however, failure in several places. But our use of revisions and nodes in filelogs is surprisingly consistent.

I just wish this could be done with a typechecker instead of these functions.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3029

To: indygreg, #hg-reviewers, durin42
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list