D3077: simplestorerepo: avoid shadowing dict in list comprehension over dict

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Apr 4 19:05:46 UTC 2018


durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Caught by pyflakes.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3077

AFFECTED FILES
  tests/simplestorerepo.py

CHANGE DETAILS

diff --git a/tests/simplestorerepo.py b/tests/simplestorerepo.py
--- a/tests/simplestorerepo.py
+++ b/tests/simplestorerepo.py
@@ -480,14 +480,14 @@
 
     def headrevs(self):
         # Assume all revisions are heads by default.
-        ishead = {rev: True for rev in self._indexbyrev}
+        revishead = {rev: True for rev in self._indexbyrev}
 
         for rev, entry in self._indexbyrev.items():
             # Unset head flag for all seen parents.
             ishead[self.rev(entry[b'p1'])] = False
             ishead[self.rev(entry[b'p2'])] = False
 
-        return [rev for rev, ishead in sorted(ishead.items())
+        return [rev for rev, ishead in sorted(revishead.items())
                 if ishead]
 
     def heads(self, start=None, stop=None):



To: durin42, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list