D3039: tests: conditionalize tests based on presence of custom extensions

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Apr 4 15:16:02 EDT 2018


indygreg added a comment.


  In https://phab.mercurial-scm.org/D3039#49612, @durin42 wrote:
  
  > In https://phab.mercurial-scm.org/D3039#49575, @indygreg wrote:
  >
  > > In https://phab.mercurial-scm.org/D3039#49541, @durin42 wrote:
  > >
  > > > Could this be more tightly integrated with --extra-config-opt?
  > >
  > >
  > > What do you mean by that?
  >
  >
  > Broadly, I'm wondering why we're adding support for an environment variable that's duplicating the functionality of --extra-config-opt, when the latter can already be used for this, and maybe we could get the test runner to read the --extra-config-opts and expose those somehow to hghave. Does that make sense? Am I talking crazy?
  
  
  So you are advocating for a more generic solution? This patch already exposes the list of extensions as an environment variable. So you want the list of extra options to be exposed instead?
  
  One reason I didn't do that is complexity: I don't want to have to parse config options from bash. It was easier to just set the list of extensions.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3039

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list