D3039: tests: conditionalize tests based on presence of custom extensions

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Apr 4 16:16:38 EDT 2018


durin42 added inline comments.

INLINE COMMENTS

> run-tests.py:1075
> +        for opt in self._extraconfigopts:
> +            section, key = opt.encode('utf-8').split(b'.', 1)
> +            name = key.split(b'=', 1)[0]

Soooooooo I'm dumb and misread this the last couple of times. Should this be doing

if section != 'extensions':

  continue?

Other than that this is what I was proposing, and I'm not sure how I misread it so badly before. :(

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3039

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list