D3125: py3: convert user value to bytes using pycompat.fsencode()

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Thu Apr 5 15:23:20 EDT 2018


pulkit added a comment.


  In https://phab.mercurial-scm.org/D3125#50284, @yuja wrote:
  
  > Unicode issue is handled by posix.py. The problem is `mockgetuser()`
  >  returns a unicode string.
  
  
  Thanks, I overlooked that and was unable to find what can cause trouble so just added an extra fsencode() call.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3125

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list