D3145: context: catch right exceptions from namespace lookup (API)
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri Apr 6 08:40:34 EDT 2018
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
It seems incorrect to me to catch LookupError of `node` returned by
a namespace API, not by a user-specified node value.
I think the reason why catching `RepoLookupError` here was that
we historically used `repo.branchtip(changeid)`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3145
To: martinvonz, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list