D3145: context: catch right exceptions from namespace lookup (API)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Apr 6 11:42:27 EDT 2018
martinvonz added a comment.
In https://phab.mercurial-scm.org/D3145#50598, @yuja wrote:
> It seems incorrect to me to catch LookupError of `node` returned by
> a namespace API, not by a user-specified node value.
The idea wasn't to catch those from the namespace API, but from changelog.rev() just after. The overly broad catching has bothered me before, so let me fix that and split this patch up.
> I think the reason why catching `RepoLookupError` here was that
> we historically used `repo.branchtip(changeid)`.
Ah, thanks for the information.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3145
To: martinvonz, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list