D3092: simplestore: shore up lookup errors
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Fri Apr 6 15:38:34 EDT 2018
durin42 added a comment.
In https://phab.mercurial-scm.org/D3092#50126, @martinvonz wrote:
> > When revisions or nodes can't be resolved, we're expected to raise
> > an error.LookupError. When I ported code from revlog.py, I failed
> > to realize that "LookupError" in that module is aliased to
> > error.LookupError. I thought we were using the builtin LookupError
> > instead.
>
> I've also recently been confused by that. Perhaps we should even rename error.LookupError to something else and avoid shadowing the builtin? StoreLookupError, perhaps?
Probably a good idea.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3092
To: indygreg, #hg-reviewers
Cc: durin42, martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list