D3118: commands: document the layering violation in `manifest --all`
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Apr 6 21:23:10 EDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG814e080a1215: commands: document the layering violation in `manifest --all` (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3118?vs=7700&id=7843
REVISION DETAIL
https://phab.mercurial-scm.org/D3118
AFFECTED FILES
mercurial/commands.py
tests/test-convert-git.t
tests/test-manifest.t
CHANGE DETAILS
diff --git a/tests/test-manifest.t b/tests/test-manifest.t
--- a/tests/test-manifest.t
+++ b/tests/test-manifest.t
@@ -1,5 +1,3 @@
-#require repobundlerepo
-
Source bundle was generated with the following script:
# hg init
@@ -12,7 +10,13 @@
# hg ci -Amb -d'1 0'
$ hg init
- $ hg -q pull "$TESTDIR/bundles/test-manifest.hg"
+ $ hg unbundle "$TESTDIR/bundles/test-manifest.hg"
+ adding changesets
+ adding manifests
+ adding file changes
+ added 2 changesets with 3 changes to 3 files
+ new changesets b73562a03cfe:5bdc995175ba
+ (run 'hg update' to get a working copy)
The next call is expected to return nothing:
@@ -64,9 +68,9 @@
l
$ hg manifest --all
- a
- b/a
- l
+ a (no-reposimplestore !)
+ b/a (no-reposimplestore !)
+ l (no-reposimplestore !)
The next two calls are expected to abort:
diff --git a/tests/test-convert-git.t b/tests/test-convert-git.t
--- a/tests/test-convert-git.t
+++ b/tests/test-convert-git.t
@@ -878,7 +878,7 @@
$ hg convert -q git-repo6 no-submodules --config convert.git.skipsubmodules=True
$ hg -R no-submodules manifest --all
- .gitmodules-renamed
+ .gitmodules-renamed (no-reposimplestore !)
convert using a different remote prefix
$ git init git-repo7
diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -3492,6 +3492,8 @@
raise error.Abort(_("can't specify a revision with --all"))
res = []
+ # TODO this is a massive layering violation. It assumes the repo is
+ # backed by revlogs with a well-defined naming scheme.
prefix = "data/"
suffix = ".i"
plen = len(prefix)
To: indygreg, #hg-reviewers, durin42
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list