D3158: histedit: look up partial nodeid as partial nodeid
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sat Apr 7 03:45:37 EDT 2018
yuja added inline comments.
INLINE COMMENTS
> yuja wrote in histedit.py:446
> Nah. It's for performance reason on ambiguous case, radix tree lookup vs linear search. I've sent a patch to fix the inconsistency,
> but it was rejected because of that.
>
> Maybe we'll need a scmutil function to document that. We shouldn't
> spill around the weird implementation detail.
BTW, it's probably wrong to rely only on _partialmatch() of unfiltered repo.
In changectx.__init__, we verify the result with `repo.changelog.rev()`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3158
To: martinvonz, durin42, #hg-reviewers, indygreg
Cc: yuja, indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list