D3215: py3: use bytes instead of str in isinstance()
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Tue Apr 10 14:15:17 UTC 2018
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We deal with bytes internally and things should be bytes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3215
AFFECTED FILES
hgext/mq.py
CHANGE DETAILS
diff --git a/hgext/mq.py b/hgext/mq.py
--- a/hgext/mq.py
+++ b/hgext/mq.py
@@ -677,7 +677,7 @@
write = self.ui.warn
if all_patches or self.ui.verbose:
- if isinstance(idx, str):
+ if isinstance(idx, bytes):
idx = self.series.index(idx)
pushable, why = self.pushable(idx)
if all_patches and pushable:
To: pulkit, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list