D3212: patch: implement a new worddiff algorithm
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Wed Apr 11 10:42:35 EDT 2018
yuja added a comment.
> That said, I'm fine with changing the defaults to whatever. So feel
> free to send follow-ups changing it.
Can you split a patch changing the color scheme so we can easily
back it out as needed?
INLINE COMMENTS
> quark wrote in patch.py:2536
> For a split list `['\n', '\t', ' ']`, mdiff might return a hunk that joins them. So `''.join(al[a1:a2])` will become more complex.
>
> I think having mdiff step free from EOL/tab handling makes the code easier to read.
Ah, got it. Let's leave mdiff refactoring until later, then.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3212
To: quark, #hg-reviewers, durin42, yuja
Cc: indygreg, dhduvall, yuja, spectral, mercurial-devel
More information about the Mercurial-devel
mailing list