[PATCH 2 of 4 V2] lfs: infer the blob store URL from paths.default

Yuya Nishihara yuya at tcha.org
Wed Apr 11 10:45:14 EDT 2018


On Wed, 11 Apr 2018 07:57:56 -0400, Matt Harbison wrote:
> >> +            url = util.url(bytes(defaulturl))
> > 
> > Nit: perhaps no need to reparse the url since defaulturl is a url object.
> 
> I don’t have the code in front of me, but I think there is an _originalpath member that doesn’t get updated when any of the components do.  It shouldn’t matter with the current code, but I wasn’t sure if that was ok to assume that in the future.

I see. Let's leave it re-parsed then.


More information about the Mercurial-devel mailing list