D3283: py3: suppress the return value of open() in tests/test-subrepo-missing.t

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Thu Apr 12 12:07:43 UTC 2018


pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  open() on Python 3 returns a value whereas does not return anything on Python 2.
  So we need to supress the value.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3283

AFFECTED FILES
  tests/test-subrepo-missing.t

CHANGE DETAILS

diff --git a/tests/test-subrepo-missing.t b/tests/test-subrepo-missing.t
--- a/tests/test-subrepo-missing.t
+++ b/tests/test-subrepo-missing.t
@@ -14,15 +14,15 @@
 
 ignore blanklines in .hgsubstate
 
-  >>> open('.hgsubstate', 'wb').write(b'\n\n   \t \n   \n')
+  >>> open('.hgsubstate', 'wb').write(b'\n\n   \t \n   \n') and None
   $ hg st --subrepos
   M .hgsubstate
   $ hg revert -qC .hgsubstate
 
 abort more gracefully on .hgsubstate parsing error
 
   $ cp .hgsubstate .hgsubstate.old
-  >>> open('.hgsubstate', 'wb').write(b'\ninvalid')
+  >>> open('.hgsubstate', 'wb').write(b'\ninvalid') and None
   $ hg st --subrepos --cwd $TESTTMP -R $TESTTMP/repo
   abort: invalid subrepository revision specifier in 'repo/.hgsubstate' line 2
   [255]



To: pulkit, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list