D2939: fsmonitor: layer on another hack in bser.c for os.stat() compat (issue5811)

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Apr 12 11:52:22 EDT 2018


indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  This is super hacky. That's par for the course for this file, sadly.
  
  Also, I'm kinda surprised we're fully realizing the Python tuple to represent stat results. If we made tuple attribute access lazy, that would probably make `hg status` a bit faster, since we never access every field of that tuple. These kinds of things never show up in Python profilers though. And it is difficult to pin performance problems on Python object creation. But we know it is a very real thing. Obviously work for another day.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2939

To: durin42, #hg-reviewers, indygreg
Cc: spectral, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list