D3303: cborutil: implement support for indefinite length CBOR types

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Apr 13 08:34:15 EDT 2018


yuja added inline comments.

INLINE COMMENTS

> cborutil.py:73
> +    beginindefinitearray(encoder)
> +    yield writeitem
> +    encoder.write(BREAK)

I don't think yielding `encoder.encode` would make much sense
because an array item can also be a nested indefinite array, in
which case, we can't use `writeitem()`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3303

To: indygreg, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list