D3289: streamclone: use command executor for wire protocol commands
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Apr 13 15:14:50 EDT 2018
indygreg updated this revision to Diff 8128.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3289?vs=8082&id=8128
REVISION DETAIL
https://phab.mercurial-scm.org/D3289
AFFECTED FILES
mercurial/streamclone.py
CHANGE DETAILS
diff --git a/mercurial/streamclone.py b/mercurial/streamclone.py
--- a/mercurial/streamclone.py
+++ b/mercurial/streamclone.py
@@ -126,11 +126,18 @@
# creation.
rbranchmap = None
if remote.capable('branchmap'):
- rbranchmap = remote.branchmap()
+ with remote.commandexecutor() as e:
+ rbranchmap = e.callcommand('branchmap', {}).result()
repo.ui.status(_('streaming all changes\n'))
- fp = remote.stream_out()
+ with remote.commandexecutor() as e:
+ fp = e.callcommand('stream_out', {}).result()
+
+ # TODO strictly speaking, this code should all be inside the context
+ # manager because the context manager is supposed to ensure all wire state
+ # is flushed when exiting. But the legacy peers don't do this, so it
+ # doesn't matter.
l = fp.readline()
try:
resp = int(l)
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list