D2880: bundle: add the possibility to bundle bookmarks (issue5792)

Sat Apr 14 12:41:44 EDT 2018

martinvonz added inline comments.

INLINE COMMENTS

> lothiraldan wrote in test-bundle-bookmarks.t:37-63
> I have added such test and indeed this case is not handled right now. I'm not aware of how Mercurial handle this case when exchanging bookmarks, I will need to take a look at the code to find out.
> 
> What is the correct behavior here? Change the existing bookmark or the bookmark from the bundle?

I think it should be the same thing as pulling from another repo. Try putting the same changes in another repo and pulling from it without giving the path a name (nothing in [paths] config). I haven't checked what suffix will be used on the divergent bookmark, but it probably makes sense to use the same here (perhaps it's just going to be "https://phab.mercurial-scm.org/D1@1" as I guessed before).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2880

To: lothiraldan, #hg-reviewers, indygreg
Cc: martinvonz, indygreg, pulkit, mercurial-devel