[PATCH STABLE] context: translate FilteredIndex/LookupError at repo[changeid] (API)

[Augie Fackler]

On Thu, Apr 19, 2018 at 04:37:34PM +0000, Martin von Zweigbergk via Mercurial-devel wrote:
> -8ba1c6dab49f at mercurial-scm.org
>
> On Thu, Apr 19, 2018 at 9:36 AM Martin von Zweigbergk <martinvonz at google.com>
> wrote:
>
> >
> >
> > On Thu, Apr 19, 2018 at 4:25 AM Yuya Nishihara <yuya at tcha.org> wrote:
> >
> >> # HG changeset patch
> >> # User Yuya Nishihara <yuya at tcha.org>
> >> # Date 1524135351 -32400
> >> #      Thu Apr 19 19:55:51 2018 +0900
> >> # Branch stable
> >> # Node ID 8ba1c6dab49f5665dc687000f149eb530a1079cf
> >> # Parent  8cde3d58cdc88707dd61a24fdccf229e2ac83610
> >> context: translate FilteredIndex/LookupError at repo[changeid] (API)
> >>
> >> This partially backs out ecd3f6909184. It seems layering violation for
> >> repo[changeid] to raise storage-level exceptions transparently. Otherwise,
> >> we would have to rewrite callers to catch all of them.
> >>
> >
> > Seems reasonable and it fixes that bug in _changectx() (thanks for
> > noticing that), so I'll queue this.
> >
> > Btw, we should also fix the "abort: 00changelog.i at abc: ambiguous
> > identifier!" message. That's clearly not meant for the user.

(martin queued these, for those following along at home)