[PATCH 1 of 2 STABLE] infinitepush: ensure fileindex bookmarks use '/' separators (issue5840)

[Matt Harbison]

> On Apr 24, 2018, at 5:21 AM, Pulkit Goyal <7895pulkit at gmail.com> wrote:
> 
> 
> 
>> On Tue, Apr 24, 2018 at 9:29 AM, Matt Harbison <mharbison72 at gmail.com> wrote:
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison at yahoo.com>
>> # Date 1524540172 14400
>> #      Mon Apr 23 23:22:52 2018 -0400
>> # Branch stable
>> # Node ID 8074f17885f9d768682cbfc11f294aba9908749d
>> # Parent  856f381ad74b78f5188a8e12648e9f7d38097c46
>> infinitepush: ensure fileindex bookmarks use '/' separators (issue5840)
>> 
>> After loading up with status messages, I noticed that the subsequent matcher was
>> rejecting 'scratch\mybranch' on Windows.  No bookmarks were reported back, and
>> the tests subsequently failed.  I did a search for 'match', and nothing else
>> looks like it needs to be fixed up, but someone who understands this code should
>> also take a look.
>> 
>> I also tried setting `infinitepush.branchpattern=re:scratch\\.*` in
>> library-infinitepush.sh without this change, but that didn't work.  Still,
>> should we ban '\' in these bookmarks to avoid confusion?  I thought I saw code
>> that sandwiches a pattern between 're:^' and '.*', so perhaps regex characters
>> will need special care?
>> 
>> I also noticed comments in externalbundlestore.{read,write} that it won't work
>> on Windows because of opening an open file.  But I don't see a test failure, so
>> this may lack test coverage.
> 
> ​Yeah, this extension still require some cleanup. Queued the series, Many thanks!​

Does the character filtering bit make any sense, and does it need to be recorded somewhere so it isn’t lost?  IDK what the big picture is here, or how bookmarks/remote bookmarks work, so this was all trial and error...

Is there an overview/plan page for infinitepush?  I’m interested in the try server aspects of this (and I’ll need the client side to work on Windows), but don’t see the big picture.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180424/ef3f9d24/attachment.html>