D4003: index: write expression for encoded revision index consistently

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Aug 1 16:44:01 UTC 2018


martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  It was sometimes "-(v + 1)" and sometimes "-v - 1" before this patch.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4003

AFFECTED FILES
  mercurial/cext/revlog.c

CHANGE DETAILS

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -1062,7 +1062,7 @@
 		v = n->children[k];
 
 		if (v == 0) {
-			n->children[k] = -rev - 1;
+			n->children[k] = -(rev + 1);
 			return 0;
 		}
 		if (v < 0) {
@@ -1072,7 +1072,7 @@
 			if (oldnode == NULL)
 				return -1;
 			if (!memcmp(oldnode, node, 20)) {
-				n->children[k] = -rev - 1;
+				n->children[k] = -(rev + 1);
 				return 0;
 			}
 			noff = nt_new(self);



To: martinvonz, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list