D4015: revlog: don't include trailing nullrev in revlog.revs(stop=len(revlog))

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Aug 1 15:29:25 EDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rHG83a505b5cf85: revlog: don't include trailing nullrev in revlog.revs(stop=len(revlog)) (authored by martinvonz, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D4015?vs=9715&id=9730

REVISION DETAIL
  https://phab.mercurial-scm.org/D4015

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -1070,12 +1070,15 @@
     def revs(self, start=0, stop=None):
         """iterate over all rev in this revlog (from start to stop)"""
         step = 1
+        length = len(self)
         if stop is not None:
             if start > stop:
                 step = -1
             stop += step
+            if stop > length:
+                stop = length
         else:
-            stop = len(self)
+            stop = length
         return xrange(start, stop, step)
 
     @util.propertycache



To: martinvonz, indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list