D4049: testrunner: allow multiple #testcases
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Aug 2 01:39:35 EDT 2018
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4049#62792, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D4049#62791, @mharbison72 wrote:
>
> > Not sure. If we can’t reuse ‘#’, maybe ‘_’ would be ok as a distinct visual identifier? I don’t think either are reserved characters.
>
>
> I was thinking of using '#'. It would be kind of nice because we already use that for specifying test cases from the command line (e.g. `run-tests.py test-foo.t#obsmarkers-on`). It would seem consistent with that to use '#' before each dimension. However, in the output files (e.g. '.err'), we use a '.' as separator. I don't know if Windows is the reason for that. A quick internet search suggested it isn't. I'll switch to that and hopefully you or someone else can tell me if it seems to work.
I inserted a parent (https://phab.mercurial-scm.org/D4052) that changes the format of .err files and changed the separator here to #. I like this much better. Hopefully it works on Windows.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4049
To: martinvonz, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel
More information about the Mercurial-devel
mailing list