D3887: rebase: support "history-editing-backup" config option

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Thu Aug 2 09:49:59 EDT 2018


yuja added a comment.


  Queued, thanks.
  
  > @@ -829,6 +833,8 @@
  > 
  >   userrevs = list(repo.revs(opts.get('auto_orphans')))
  >   opts['rev'] = [revsetlang.formatspec('%ld and orphan()', userrevs)]
  >   opts['dest'] = '_destautoorphanrebase(SRC)'
  > 
  > +    backup = ui.configbool('ui', 'history-editing-backup')
  >  +    opts['backup'] = backup
  
  This seems getting ugly. Maybe the option can be carried by rbsrt instead?
  
    self.backupf = ui.configbool('ui', 'history-editing-backup')

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3887

To: khanchi97, #hg-reviewers
Cc: pulkit, yuja, mercurial-devel


More information about the Mercurial-devel mailing list