D4057: narrowspec: use sparse.parseconfig() to parse narrowspec file (BC)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Aug 2 17:03:47 EDT 2018


martinvonz added inline comments.

INLINE COMMENTS

> narrowspec.py:143
>          raise
> -    return _parsestoredpatterns(spec)
> +    # we should care about the profiles returned too
> +    includepats, excludepats, __ = sparse.parseconfig(repo.ui, spec, 'narrow')

We should at least abort if they're in there. I think we should add that check already in this patch.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4057

To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list