D4049: testrunner: allow multiple #testcases

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Fri Aug 3 02:01:39 EDT 2018


mharbison72 accepted this revision.
mharbison72 added a comment.


  In https://phab.mercurial-scm.org/D4049#63026, @martinvonz wrote:
  
  > In https://phab.mercurial-scm.org/D4049#63024, @mharbison72 wrote:
  >
  > > In https://phab.mercurial-scm.org/D4049#63019, @martinvonz wrote:
  > >
  > > > In https://phab.mercurial-scm.org/D4049#63018, @mharbison72 wrote:
  > > >
  > > > > I'm getting an import error, and I'm not sure how to figure out the parent revision from phab.
  > > >
  > > >
  > > > Make sure you're applying it onto @ from https://www.mercurial-scm.org/repo/hg-committed/. If not, you'll probably have to import https://phab.mercurial-scm.org/D4052 before this patch (https://phab.mercurial-scm.org/D4052 is in @ on hg-committed).
  > >
  > >
  > > Maybe needs a push?  I'm seeing @ on https://phab.mercurial-scm.org/D4048 on hg-committed.
  >
  >
  > Sorry, I was just misremembering that https://phab.mercurial-scm.org/D4052 had been queued. I don't know why phabricator doesn't understand that this patch is on top of https://phab.mercurial-scm.org/D4052. Anyway, try applying https://phab.mercurial-scm.org/D4052 first, then this one.
  
  
  That did the trick, and this runs clean on Windows, thanks.
  
  It seems to add ~4 seconds to test-run-tests.t, but that's probably not a big deal if it doesn't affect all of the other tests like this.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4049

To: martinvonz, #hg-reviewers, mharbison72
Cc: quark, lothiraldan, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list