D3988: resolve: add confirm config option

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Aug 3 13:26:56 EDT 2018


martinvonz added inline comments.

INLINE COMMENTS

> configitems.py:193
>  )
> +coreconfigitem('commands', 'resolve.confirm',
> +    default=False,

Is this name too generic? It's specifically for confirming re-resolve with `--all`. I can imagine having confirmation for marking files as resolved and I'm not sure we'd want to share the config option if we ever added such a feature. It might also make the name clearer if it was something like `resolve.confirmreresolve` or `resolve.confirmredo` or `resolve.confirmoverwrite`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3988

To: khanchi97, #hg-reviewers, pulkit
Cc: martinvonz, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list