D3988: resolve: add confirm config option
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Fri Aug 3 13:32:06 EDT 2018
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in configitems.py:193
> Is this name too generic? It's specifically for confirming re-resolve with `--all`. I can imagine having confirmation for marking files as resolved and I'm not sure we'd want to share the config option if we ever added such a feature. It might also make the name clearer if it was something like `resolve.confirmreresolve` or `resolve.confirmredo` or `resolve.confirmoverwrite`.
For now, yes the name is generic. My plan with @khanchi97 on this is to respect this option with other flags too. Like `hg resolve -m` will ask before marking as resolve if this config option is set.
Once we are done with other flags too, this won't sound generic.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3988
To: khanchi97, #hg-reviewers, pulkit
Cc: martinvonz, pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list