D4040: shortest: make isrev() a top-level function

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Aug 3 17:51:00 EDT 2018


martinvonz marked an inline comment as done.
martinvonz added inline comments.

INLINE COMMENTS

> pulkit wrote in scmutil.py:492
> This looks unrelated here.

Not completely unrelated. I moved it down here because it's no longer needed until here. It was used on line 478 before (and given Python scoping rules, it could have been moved down even before this patch, but that makes it harder to read IMO).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4040

To: martinvonz, #hg-reviewers, lothiraldan
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list