D4039: [RFC] shortest: cache disambiguation revset

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Aug 3 23:10:28 EDT 2018


yuja added a comment.


  >   This doesn't seem like the right way to cache it. Suggestions?
  
  Suppose the cache exists mainly for templating, templatefuncs.shortest()
  can pass in a cached revset to resolvehexnodeidprefix(), and we don't have
  to take care of cache invalidation.
  
  If we want to cache a prefix tree, maybe it could be turned into a "resolver"
  object which the templater creates at the first shortest() call.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4039

To: martinvonz, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list