D4081: changegroup: consolidate tree manifests sending into cg1packer

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Aug 6 03:29:03 EDT 2018


martinvonz added inline comments.

INLINE COMMENTS

> changegroup.py:671
>  
> +    def _packtreemanifests(self, dir, mfnodes, lookuplinknode):
> +        """Version of _packmanifests that operates on directory manifests.

Note that this also works for flat manifests (IIRC). You should be able always use this version, as long as you remove the assertion. You can perhaps move the assertion 3 lines down into the `if dir:` block.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4081

To: indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list