D4144: changegroup: assign to proper attribute

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Mon Aug 6 23:46:15 UTC 2018


indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  https://phab.mercurial-scm.org/rHG0548f696795b6f30c32f11620ddc274a112260d3 accidentally assigned to self.clrevtolocalrev instead of
  self._clrevtolocalrev. Surprisingly, no tests failed as a result of
  this mistake. Curious.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4144

AFFECTED FILES
  mercurial/changegroup.py

CHANGE DETAILS

diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -671,7 +671,7 @@
         # Ellipses serving mode.
         self._clrevtolocalrev.clear()
         if self._nextclrevtolocalrev:
-            self.clrevtolocalrev = self._nextclrevtolocalrev
+            self._clrevtolocalrev = self._nextclrevtolocalrev
             self._nextclrevtolocalrev.clear()
 
         return closechunk()



To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list