D4088: changegroup: move revision maps to cgpacker

[indygreg (Gregory Szorc)]

indygreg added subscribers: spectral, martinvonz, durin42.
indygreg added inline comments.

INLINE COMMENTS

> changegroup.py:599-600
> +        if self._nextclrevtolocalrev:
> +            self.clrevtolocalrev = self._nextclrevtolocalrev
> +            self._nextclrevtolocalrev.clear()
>          self._changelogdone = True

There are 2 bugs here.

One is dropping the `_` prefix from `clrevtolocalrev`.

The other is aliasing the variables then calling `.clear()`, which has the effect of undoing both and effectively nerfing `self._nextclrevtolocalrev`.

Surprisingly no tests failed as a result of these bugs. So I'm not sure what's going on.

Maybe @spectral, @martinvonz, or @durin42 know what's up.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4088

To: indygreg, #hg-reviewers
Cc: durin42, martinvonz, spectral, mercurial-devel