D4180: tests: rename variables in revlog index parse test for clarity

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Thu Aug 9 17:42:10 UTC 2018


durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Now it's unambiguous which one is the expected value. c_res_{1,2} was
  also misleading a bit because in --pure mode we're testing the old
  slow Python version against the modern optimized Python version.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4180

AFFECTED FILES
  tests/test-parseindex2.py

CHANGE DETAILS

diff --git a/tests/test-parseindex2.py b/tests/test-parseindex2.py
--- a/tests/test-parseindex2.py
+++ b/tests/test-parseindex2.py
@@ -183,13 +183,13 @@
        # Check parsers.parse_index2() on an index file against the original
        # Python implementation of parseindex, both with and without inlined data.
 
-        py_res_1 = py_parseindex(data_inlined, True)
-        c_res_1 = parse_index2(data_inlined, True)
-        self.assertEqual(py_res_1, c_res_1) # inline data
+        want = py_parseindex(data_inlined, True)
+        got = parse_index2(data_inlined, True)
+        self.assertEqual(want, got) # inline data
 
-        py_res_2 = py_parseindex(data_non_inlined, False)
-        c_res_2 = parse_index2(data_non_inlined, False)
-        self.assertEqual(py_res_2, c_res_2) # no inline data
+        want = py_parseindex(data_non_inlined, False)
+        got = parse_index2(data_non_inlined, False)
+        self.assertEqual(want, got) # no inline data
 
         ix = parsers.parse_index2(data_inlined, True)[0]
         for i, r in enumerate(ix):



To: durin42, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list