D4209: changegroup: move manifest chunk emission to generate()

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Aug 9 22:19:27 EDT 2018


indygreg added inline comments.

INLINE COMMENTS

> durin42 wrote in changegroup.py:879
> nit: this shadows the dir() builtin, which makes me a bit uncomfortable - send a followup?
> 
> ("tree" maybe?)

This bothered me as well. I will happily submit a follow-up. Will tack it at the end of my current series.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4209

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list