D4162: index: don't include nullid in the internal "length" field
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Aug 9 23:51:47 EDT 2018
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4162#64736, @durin42 wrote:
> Can I interest you in adding a test for `len(index)` to `test-parseindex2.py`? I suspect we have some differences between pure and C code right now...
Ah, that test is already failing. I sent https://phab.mercurial-scm.org/D4241 to fix that. I think it already checks the length via the `==` operator (i.e. `py_res_1 != c_res_1` would have failed if the length didn't match).
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4162
To: martinvonz, #hg-reviewers
Cc: durin42, mercurial-devel
More information about the Mercurial-devel
mailing list