D4262: zsh_completion: drop -w, add -S to _arguments

spectral (Kyle Lippincott) phabricator at mercurial-scm.org
Mon Aug 13 15:02:12 EDT 2018


spectral added a comment.


  In https://phab.mercurial-scm.org/D4262#65777, @av6 wrote:
  
  > Thanks, `‘` and `’`, for making it difficult to phabsend this. I had to
  >
  >   diff --git a/contrib/phabricator.py b/contrib/phabricator.py
  >   --- a/contrib/phabricator.py
  >   +++ b/contrib/phabricator.py
  >   @@ -117,6 +117,8 @@ def urlencodenested(params):
  >        def process(prefix, obj):
  >            items = {list: enumerate, dict: lambda x: x.items()}.get(type(obj))
  >            if items is None:
  >   +            if isinstance(obj, unicode):
  >   +                obj = obj.encode('utf-8')
  >                flatparams[prefix] = obj
  >            else:
  >                for k, v in items(obj):
  >
  >
  > But having word diff for this series makes up for the frustration, I think.
  
  
  Can you send that patch too (maybe you already have, just not to phabricator... I don't generally follow mercurial-devel@)?  I've also encountered unicode issues with phabsend, but didn't have the time or ability to track it down and just removed the unicode from my commit description :)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4262

To: av6, #hg-reviewers, spectral
Cc: mercurial-devel


More information about the Mercurial-devel mailing list