D4285: tests: conditionalize extension tests for extra extensions

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Aug 16 00:44:25 UTC 2018


indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  If extra extensions are loaded (e.g. via --extra-config-opt),
  the tests conditionalized in this commit fail in ways that
  are dependent on the extensions that are loaded. So let's
  skip them when that scenario is present.
  
  This drops the number of failures for the simplestorerepo.py
  extension to 4.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4285

AFFECTED FILES
  tests/test-bad-extension.t
  tests/test-extension.t

CHANGE DETAILS

diff --git a/tests/test-extension.t b/tests/test-extension.t
--- a/tests/test-extension.t
+++ b/tests/test-extension.t
@@ -1540,13 +1540,15 @@
   reposetup() for $TESTTMP/reposetup-test/src
   reposetup() for $TESTTMP/reposetup-test/src (chg !)
 
+#if no-extraextensions
   $ hg --cwd src debugextensions
   reposetup() for $TESTTMP/reposetup-test/src
   dodo (untested!)
   dudu (untested!)
   mq
   reposetuptest (untested!)
   strip
+#endif
 
   $ hg clone -U src clone-dst1
   reposetup() for $TESTTMP/reposetup-test/src
diff --git a/tests/test-bad-extension.t b/tests/test-bad-extension.t
--- a/tests/test-bad-extension.t
+++ b/tests/test-bad-extension.t
@@ -72,6 +72,7 @@
   $ hg --config extensions.badexts=showbadexts.py showbadexts 2>&1 | grep '^BADEXTS'
   BADEXTS: badext badext2
 
+#if no-extraextensions
 show traceback for ImportError of hgext.name if devel.debug.extensions is set
 
   $ (hg help help --traceback --debug --config devel.debug.extensions=yes 2>&1) \
@@ -120,6 +121,7 @@
   debug.extensions: - loading extension registration objects
   debug.extensions: > extension registration object loading took * (glob)
   debug.extensions: extension loading complete
+#endif
 
 confirm that there's no crash when an extension's documentation is bad
 



To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list