D4309: dagutil: remove nodeset()

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Aug 16 20:44:07 UTC 2018


indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  AFAICT this was unused since the code was introduced by https://phab.mercurial-scm.org/rHGcb98fed5249517b558fa07c7d0414c14cdfe4e4d
  in 2011!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4309

AFFECTED FILES
  mercurial/dagutil.py

CHANGE DETAILS

diff --git a/mercurial/dagutil.py b/mercurial/dagutil.py
--- a/mercurial/dagutil.py
+++ b/mercurial/dagutil.py
@@ -24,10 +24,6 @@
     def __init__(self):
         self._inverse = None
 
-    def nodeset(self):
-        '''set of all node ixs'''
-        raise NotImplementedError
-
     def heads(self):
         '''list of head ixs'''
         raise NotImplementedError
@@ -92,14 +88,10 @@
 class revlogbaseddag(basedag):
     '''generic dag interface to a revlog'''
 
-    def __init__(self, revlog, nodeset):
+    def __init__(self, revlog):
         basedag.__init__(self)
         self._revlog = revlog
         self._heads = None
-        self._nodeset = nodeset
-
-    def nodeset(self):
-        return self._nodeset
 
     def heads(self):
         if self._heads is None:
@@ -110,7 +102,7 @@
     '''dag interface to a revlog'''
 
     def __init__(self, revlog, localsubset=None):
-        revlogbaseddag.__init__(self, revlog, set(revlog))
+        revlogbaseddag.__init__(self, revlog)
         self._heads = localsubset
 
     def _getheads(self):
@@ -204,7 +196,7 @@
     '''inverse of an existing revlog dag; see revlogdag.inverse()'''
 
     def __init__(self, orig):
-        revlogbaseddag.__init__(self, orig._revlog, orig._nodeset)
+        revlogbaseddag.__init__(self, orig._revlog)
         self._orig = orig
         self._children = {}
         self._roots = []



To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list