D4322: setdiscovery: don't use dagutil for parent resolution
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sat Aug 18 04:05:31 EDT 2018
yuja added a comment.
> + # TODO this is quadratic
> + parentfn = lambda rev: repo.changelog.children(repo.changelog.node(rev))
> +
> + _updatesample(revs, revsroots, sample, parentfn)
Here `parentfn()` returns a list of nodes, which is wrong. But I took this
since this code is completely rewritten.
Surprisingly, test-setdiscovery.t didn't fail at this revision.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4322
To: indygreg, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list