D4120: shortest: use nodetree for finding shortest node within revset

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon Aug 20 18:51:57 EDT 2018


yuja added a comment.


  test-revisions.t fails probably because null. I've queued up to the previous
  patch.
  
  >   static int nt_init_py(nodetree *self, PyObject *args)
  >   {
  > 
  > - PyObject *index; +  indexObject *index;
  
  Dropped this change as it's unrelated to this patch, and the index variable
  is casted to indexObject* anyway.
  
  >   	unsigned capacity;
  > 
  > - if (!PyArg_ParseTuple(args, "O!I", &index, &capacity)) +	if (!PyArg_ParseTuple(args, "O!I", &indexType, &index, &capacity)) 		return -1;
  
  Moved this to https://phab.mercurial-scm.org/D4118.
  
  >   	return nt_init(self, (indexObject*)index, capacity);

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4120

To: martinvonz, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list