D4339: index: fix a comment about overflow-checking

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Aug 20 22:58:42 UTC 2018


martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  There's no "argument-checking" done in this method. This was a bad
  copy paste.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4339

AFFECTED FILES
  mercurial/cext/revlog.c

CHANGE DETAILS

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -1095,7 +1095,7 @@
 
 static int nt_init(nodetree *self, indexObject *index, unsigned capacity)
 {
-	/* Initialize before argument-checking to avoid nt_dealloc() crash. */
+	/* Initialize before overflow-checking to avoid nt_dealloc() crash. */
 	self->nodes = NULL;
 
 	self->index = index;



To: martinvonz, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list