D4120: shortest: use nodetree for finding shortest node within revset

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In https://phab.mercurial-scm.org/D4120#66662, @yuja wrote:
  
  > test-revisions.t fails probably because null.
  
  
  Hmm, it passes for me. How does it fail for you?
  
  > I've queued up to the previous
  >  patch.
  > 
  >>   static int nt_init_py(nodetree *self, PyObject *args)
  >>   {
  >> 
  >> - PyObject *index; +  indexObject *index;
  > 
  > Dropped this change as it's unrelated to this patch, and the index variable
  >  is casted to indexObject* anyway.
  > 
  >>   	unsigned capacity;
  >> 
  >> - if (!PyArg_ParseTuple(args, "O!I", &index, &capacity)) +	if (!PyArg_ParseTuple(args, "O!I", &indexType, &index, &capacity)) 		return -1;
  > 
  > Moved this to https://phab.mercurial-scm.org/D4118.
  > 
  >>   	return nt_init(self, (indexObject*)index, capacity);
  
  Thanks!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4120

To: martinvonz, #hg-reviewers
Cc: yuja, mercurial-devel